fix(crud-toolbar): flickering in refresh button COMPASS-8138 #7384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given the different size between refresh button and loading spinner, a flicker was visible when switching between states. This PR fixes that flickering.
Before:
After:
refresh-button-flickering-fixed.mov
Checklist
Motivation and Context
Open Questions
There's still one flickering because when we jump into the loading state, we reset the counter until it's calculated again, causing the page size selector to reflow and the counter to hide/show. Any ideas on how to improve this?
Dependents
Types of changes